Fix missed samples stat in object mode #109
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When profiling in
object
mode, the sample miss rate is incorrectly calculated.overall_signals
is incremented every time a new object is allocated, however we only want to capture a sample everyinterval
. This all but guarantees a miss rate of > 99% when profiling inobject
mode, which isn't accurate.Solution
Add a new member to the
_stackprof
struct,newobj_signals
, that we can use to track the number of allocations. If it's determined that we should capture a sample, then increment theoverall_signals
member. This should make the miss rate accurate again.