add start_time_nsecs to profile info
#229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the profile data structure with a new
start_time_nsecsfield holding a timestamp (in nanos) since EPOCHRight now, it is impossible to tell when a profile was really capture, and while that is not really relevant when inspecting individual profiles, it definite is when it comes to usage in aggregates when performing any sort of 'continuous' profiling.
For most Shopify apps, we initially resorted to encode and try to parse the time from generated objects after capturing the profile, but that is turning out to be too brittle and hard to maintain due to the amount of workloads we have around