Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truncated text in about page in horizontal view #133

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix truncated text in about page in horizontal view #133

merged 1 commit into from
Nov 13, 2023

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Nov 6, 2023

No description provided.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Nov 6, 2023

Here is a screenshot of the about page before this fix. See texts are not shown in top and bottom lines.

image

This is fixed by adding a scroll view.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Nov 6, 2023

p.s. The diff may look bigger but most of it is just for indentation.

@tmo1
Copy link
Owner

tmo1 commented Nov 9, 2023

Hi,

Thanks for working on this. Can you please try to modify the patch to reduce the size of the diff? It's difficult to review in the current form.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Nov 9, 2023

I have removed the indentation changes in new commit.

@tmo1 tmo1 merged commit 9d6b516 into tmo1:master Nov 13, 2023
1 check passed
@tmo1
Copy link
Owner

tmo1 commented Nov 13, 2023

Thank you!

@Biswa96 Biswa96 deleted the fix-about-page-horizontal branch November 13, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Biswa96 @tmo1