Added mininal assume-role support #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The library now supports the default AWS credential stuff (AWS_PROFILE env, reading from ~/.aws/credentials, etc.). It doesn't do anything fancy and just delegates all credential stuff to the AWS SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be a bit clumsy, in theory AWS SDK should support picking
credential_sourcefrom profile file out-of the box, but the support hasn't been implemented yet (tracking: aws/aws-sdk-js#1916)So, I assumed, that even if try to pick up a profile via
--profileand it failed to initialize, it still good to use SDK defaults https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/CredentialProviderChain.html#defaultProviders-propertyAlso, added
package-lock.json, due to NPM recommendations. https://docs.npmjs.com/files/package-locks#using-locked-packages