fix fail-on-success-after-retry scenario

tmornini · Feb 15, 2018 · a466057 · a466057
1 parent 812728d
commit a466057
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/07-desired-request-sender.go b/07-desired-request-sender.go
@@ -35,20 +35,26 @@ func desiredRequestSender(context *context) {
 
 	context.SpecTriplet.StartedAt = time.Now()
 
-	for attempt := 1; attempt <= context.MaxHTTPAttempts; attempt++ {
+	attempt := 0
+
+	for {
 		context.HTTPResponse, err = context.HTTPClient.Do(request)
 
-		if errorHandler(context, err) {
-			if attempt < context.MaxHTTPAttempts {
-				time.Sleep(context.HTTPRetryDelay)
+		attempt++
+
+		if err == nil {
+			break
+		}
 
-				continue
-			}
+		if attempt >= context.MaxHTTPAttempts {
+			context.Err = err
 
 			return
 		}
 
-		break
+		time.Sleep(context.HTTPRetryDelay)
+
+		continue
 	}
 
 	actualResponseReceiver(context)