Unit test and fixed bug #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Python repository[2] with exclusive tests for this library. Refs: [1] https://github.com/catchorg/Catch2 [2] https://github.com/seatgeek/fuzzywuzzy/blob/master/test_fuzzywuzzy.py
```
ReadmeExample (test_readme.cpp)
FAILED:
REQUIRE( 97 == fuzz::ratio("this is a test", "this is a test!") );
EXPANSION:
97 == 100
```
The `full_process` is default on and will strip the tailing exclamation mark.
It was fixed by altering the default value of `full_process` to false.
set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON)
```
RaioTest
testEmptyStringsScore100
FAILED:
REQUIRE( 100 == fuzz::ratio("", "") )
EXPANSION:
100 == 0
```
Fixed by checking empty string in `fuzz::ratio` and `fuzz:partial_ratio`.
``` RatioTest testPartialRatio FAILED: REQUIRE( 100 == fuzz::partial_ratio(s1, s1) ) EXPANSION: 100 == 0 ``` The `partial_ratio` of two identical strings should be 100 undoubtedly. The detailed description of this problem is written in the `fuzzywuzzy.cpp`.
1) How to build and run tests 2) Enable command `make test`
|
Thanks for taking the time to port unit tests over! I'll see about going over the commits the coming week. |
|
Just let me know if there is anything goes wrong or needs to be updated. ^_^ |
tmplt
requested changes
Mar 31, 2020
tmplt
reviewed
Mar 31, 2020
Okay, I think make it as an installed package or something likewise is more proper. Will be added in the next commit. |
1) Catch2 libray now need to be installed or placed in include path to build successfully 2) Add comments to describle the commented out testcases in `test_fuzzywuzzy.cpp`
|
I had updated the required change. Please review the code changes in this new commit. |
tmplt
requested changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following updates:
Unit Test
testfolder as before.CMakeLists.txtandREADME.mdto provide instruction of building and running unit test.Fixed Bugs
full_processis default on and will strip the tailing exclamation mark. It was fixed by altering the default value offull_processtofalse.ratio()andpartial_ratio().partial_ratio()of two identical string is 0% similarity which should be 100% undoubtedly. The detailed description is in thefuzzywuzzy.cpp. This was fixed by a temporary solution to compare if two strings is identical or not.