MSH-492 Fix cohort-enrol course cohort sync #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a cohort-enrol -c XX "cohortname" is run and the id for "cohortname" matches another `customint1` in the `mdl_enrol` table for that course, it will state that the cohort is already enrolled when it's not. This verifies that the `customint1` is for the `cohort` enrol type.
|
Thank you @martygilbert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cohort-enrol -c XX "cohortname" is run and the id for "cohortname" matches another
customint1in themdl_enroltable for that course, it will state that the cohort is already enrolled when it's not. This verifies that thecustomint1is for thecohortenrol type.The fix was just to add
'enrol' => 'cohort'to make sure that we're only looking at enrollment plugins wherecustomint1matches AND it's a cohort sync enrollment.Edit to add: This closes #492