Use window_id/pane_id for current_pane_logging. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior code used window_index/pane_index which were not unique. If a window/pane is destroyed with logging enabled and then recreated, state in current_pane_logging will still indicate that logging is on while in reality it is off.
mosheDO
approved these changes
May 30, 2021
|
Hi @modax Did u test that this it doesn't break anything ? Regards Moshe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior code used window_index/pane_index which were not unique. If a
window/pane is destroyed with logging enabled and then recreated, state
in current_pane_logging will still indicate that logging is on while in
reality it is off.