-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved splitting #532
Merged
Merged
Improved splitting #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
pane-split-window
branch
5 times, most recently
from
March 3, 2024 19:32
8265d2b
to
13fd232
Compare
tony
changed the title
feat(Pane): Add
Improved splitting
Mar 3, 2024
Pane.split()
, deprecate Pane.split_window()
tony
force-pushed
the
pane-split-window
branch
17 times, most recently
from
March 10, 2024 10:53
85315a7
to
fad6a94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 88.38% 88.72% +0.33%
==========================================
Files 37 37
Lines 3798 3965 +167
Branches 549 573 +24
==========================================
+ Hits 3357 3518 +161
- Misses 304 307 +3
- Partials 137 140 +3 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
pane-split-window
branch
5 times, most recently
from
March 10, 2024 12:31
6b09466
to
3060a4b
Compare
tony
force-pushed
the
pane-split-window
branch
6 times, most recently
from
March 16, 2024 20:17
5cf290a
to
91ff4b1
Compare
tony
added a commit
that referenced
this pull request
Mar 17, 2024
tony
added a commit
that referenced
this pull request
Mar 17, 2024
Merged
tony
added a commit
that referenced
this pull request
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New param:
Session.new_window()
direction
:WindowDirection
(Before
,After
)New method:
Pane.split()
New param:
direction
, viaPaneDirection
(Above
,Below
,Left
,Right
)Replaces
vertical
's old behavior.New param:
full_window_split
Deprecate
Pane.split_window()
New method:
Window.split()
New param:
direction
, viaPaneDirection
(Above
,Below
,Left
,Right
)Replaces
vertical
's old behavior.New param:
full_window_split
,zoom
Deprecate
Window.split_window()