Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved splitting #532

Merged
merged 29 commits into from
Mar 17, 2024
Merged

Improved splitting #532

merged 29 commits into from
Mar 17, 2024

Conversation

tony
Copy link
Member

@tony tony commented Mar 3, 2024

Changes

New param: Session.new_window()

  • direction: WindowDirection (Before, After)

New method: Pane.split()

  • New param: direction, via PaneDirection (Above, Below, Left, Right)

    Replaces vertical's old behavior.

  • New param: full_window_split

Deprecate Pane.split_window()

New method: Window.split()

  • New param: direction, via PaneDirection (Above, Below, Left, Right)

    Replaces vertical's old behavior.

  • New param: full_window_split, zoom

Deprecate Window.split_window()

@tony tony force-pushed the pane-split-window branch 5 times, most recently from 8265d2b to 13fd232 Compare March 3, 2024 19:32
@tony tony changed the title feat(Pane): Add Pane.split(), deprecate Pane.split_window() Improved splitting Mar 3, 2024
@tony tony force-pushed the pane-split-window branch 17 times, most recently from 85315a7 to fad6a94 Compare March 10, 2024 10:53
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 93.48659% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 88.72%. Comparing base (6ea527b) to head (0503da8).

Files Patch % Lines
src/libtmux/pane.py 77.19% 10 Missing and 3 partials ⚠️
tests/test_window.py 96.61% 0 Missing and 2 partials ⚠️
src/libtmux/window.py 92.30% 0 Missing and 1 partial ⚠️
tests/test_session.py 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   88.38%   88.72%   +0.33%     
==========================================
  Files          37       37              
  Lines        3798     3965     +167     
  Branches      549      573      +24     
==========================================
+ Hits         3357     3518     +161     
- Misses        304      307       +3     
- Partials      137      140       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the pane-split-window branch 5 times, most recently from 6b09466 to 3060a4b Compare March 10, 2024 12:31
@tony tony force-pushed the pane-split-window branch 6 times, most recently from 5cf290a to 91ff4b1 Compare March 16, 2024 20:17
@tony tony merged commit 77047c6 into master Mar 17, 2024
25 checks passed
@tony tony deleted the pane-split-window branch March 17, 2024 08:23
tony added a commit that referenced this pull request Mar 17, 2024
tony added a commit that referenced this pull request Mar 17, 2024
@tony tony mentioned this pull request Mar 17, 2024
tony added a commit that referenced this pull request Mar 17, 2024
tony added a commit that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant