Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.22.0: test_window_shell fails #855

Open
dvzrv opened this issue Dec 28, 2022 · 3 comments
Open

1.22.0: test_window_shell fails #855

dvzrv opened this issue Dec 28, 2022 · 3 comments

Comments

@dvzrv
Copy link

dvzrv commented Dec 28, 2022

Step 1: Provide a summary of your problem

When packaging 1.22.0, the test test_window_shell fails.

Step 2: Provide tmuxp details

n/a

Step 3: Describe the problem:

Steps to reproduce:

Same as in my other tickets

Observed Results:

=================================== FAILURES ===================================
______________________________ test_window_shell _______________________________

session = Session($1 libtmux_a2zoq8m_)

    def test_window_shell(session):
        workspace = ConfigReader._from_file(
            test_utils.get_workspace_file("workspace/builder/window_shell.yaml")
        )
        workspace = loader.expand(workspace)

        builder = WorkspaceBuilder(sconf=workspace)

>       for w, wconf in builder.iter_create_windows(session):

tests/workspace/test_builder.py:319:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
test_dir/usr/lib/python3.10/site-packages/tmuxp/workspace/builder.py:376: in iter_create_windows
    w = session.new_window(
/usr/lib/python3.10/site-packages/libtmux/session.py:552: in new_window
    return Window.from_window_id(
/usr/lib/python3.10/site-packages/libtmux/window.py:92: in from_window_id
    window = fetch_obj(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

server = Server(socket_name=libtmux_testeupg4wcy), obj_key = 'window_id'
obj_id = '@2', list_cmd = 'list-windows', list_extra_args = ('-a',)

    def fetch_obj(
        server: "Server",
        obj_key: str,
        obj_id: str,
        list_cmd: "ListCmd" = "list-panes",
        list_extra_args: "ListExtraArgs" = None,
    ) -> OutputRaw:
        obj_formatters_filtered = fetch_objs(
            server=server, list_cmd=list_cmd, list_extra_args=list_extra_args
        )

        obj = None
        for _obj in obj_formatters_filtered:
            if _obj.get(obj_key) == obj_id:
                obj = _obj

>       assert obj is not None
E       assert None is not None

/usr/lib/python3.10/site-packages/libtmux/neo.py:242: AssertionError
=========================== short test summary info ============================
FAILED tests/workspace/test_builder.py::test_window_shell - assert None is no...

tmuxp-1.22.0-1-x86_64-check.log

Expected Results:

All tests pass

Relevant Code:

n/a

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 28, 2022
Disable another broken test: tmux-python/tmuxp#855

git-svn-id: file:///srv/repos/svn-community/svn@1369857 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 28, 2022
Disable another broken test: tmux-python/tmuxp#855

git-svn-id: file:///srv/repos/svn-community/svn@1369857 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@tony
Copy link
Member

tony commented Dec 28, 2022

Thank you for this. Not reproducing this on our CI yet!

@dvzrv Which version of libtmux?

@dvzrv
Copy link
Author

dvzrv commented Dec 28, 2022

plugins: rerunfailures-10.3, mock-3.10.0, libtmux-0.18.0

@tony
Copy link
Member

tony commented Dec 28, 2022

@dvzrv By the way - is there a way, I will look at https://github.com/uraimo/run-on-arch-action having end-to-end arch tests on our CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants