Skip to content

WorkspaceBuilder: Harden typings #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 30, 2022
Merged

WorkspaceBuilder: Harden typings #857

merged 8 commits into from
Dec 30, 2022

Conversation

tony
Copy link
Member

@tony tony commented Dec 29, 2022

  • feat(WorkspaceBuilder): Require server in constructor

Related to #856

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #857 (583156d) into master (25ce991) will not change coverage.
The diff coverage is n/a.

❗ Current head 583156d differs from pull request most recent head ac95450. Consider uploading reports for the commit ac95450 to get more accurate results

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   71.07%   71.07%           
=======================================
  Files          25       25           
  Lines        1829     1829           
  Branches      405      405           
=======================================
  Hits         1300     1300           
  Misses        411      411           
  Partials      118      118           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the cli-load-builder-issues branch 5 times, most recently from 4f297aa to 7212148 Compare December 29, 2022 17:12
@tony tony force-pushed the cli-load-builder-issues branch from 64e0f97 to dc190e2 Compare December 29, 2022 20:04
@tony tony linked an issue Dec 29, 2022 that may be closed by this pull request
@tony tony force-pushed the cli-load-builder-issues branch 3 times, most recently from 9e15aa6 to e098996 Compare December 30, 2022 16:38
@tony tony force-pushed the cli-load-builder-issues branch from e098996 to ac95450 Compare December 30, 2022 20:43
@tony tony force-pushed the cli-load-builder-issues branch from ac95450 to 5cbafd6 Compare December 30, 2022 20:45
@tony tony merged commit 1fe212f into master Dec 30, 2022
@tony tony deleted the cli-load-builder-issues branch December 30, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder: Race conditions after #796 / strict mypy
1 participant