Allow arrays of certs to be provided #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings the `signingCert` and `encryptCert` args on the entities up to parity with raw metadata when multiple KeyDescriptors are desired for each use. fixes tngan#497
Items my IDE pointed out as I poked around.
|
@mastermatt Thanks for bringing this. I will merge this PR first, we will need to consume in signature verification & encryption function if multiple certificates are given. |
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the
signingCertandencryptCertargs on the entities up to parity with raw metadata when multiple KeyDescriptors are desired for each use.@tngan