Fix pathing issues for coffee #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doubt this will work in a windows environment. Need to learn more about rake so I can do it in a more cross-platform fashion. |
| @@ -4,8 +4,8 @@ task :default => [:build] | |||
|
|
|||
| desc 'Create js files from coffee sources' | |||
| task :build do | |||
| system("cd #{root} && bundle exec coffee --compile --output . src/isolate.coffee") | |||
| system("cd #{root} && bundle exec coffee --compile spec") | |||
| system("cd #{root} && bundle exec `npm bin`/coffee --compile --output . src/isolate.coffee") | |||
There was a problem hiding this comment.
since we're already cd-ing into the directory of the Rakefile, can't we just directly path to node_modules/.bin/coffee ?
though I do like the use of npm bin. I'll check it in my windows environment now.
There was a problem hiding this comment.
Oh yeah, didn't see that.
Sent from my iPhone
On Mar 22, 2013, at 8:30 PM, James Maroney notifications@github.com wrote:
In Rakefile:
@@ -4,8 +4,8 @@ task :default => [:build]
desc 'Create js files from coffee sources'
task :build do
- system("cd #{root} && bundle exec coffee --compile --output . src/isolate.coffee")
- system("cd #{root} && bundle exec coffee --compile spec")
- system("cd #{root} && bundle exec
npm bin/coffee --compile --output . src/isolate.coffee")
since we're already cd-ing into the directory of the Rakefile, can't we just directly path to node_modules/.bin/coffee ?—
Reply to this email directly or view it on GitHub.
Here are some updates that make the commands seem to execute cross-platform. Sadly, they still don't behave correctly in Windows, so this certainly isn't 100% right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3. Changed all npm executable references to use
npm binto resolve the correct path.