Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for packages without setup.py #16

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Oct 13, 2022

Following the doc from setuptools, when there's no setup.py file it's possible to use a simple one with just the call to setup() that will get the data from pyproject.toml:
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#configuring-setuptools-using-pyproject-toml-files

This should fix the issue in py2pack trying to generate from projects that doesn't provide a setup.py file:
openSUSE/py2pack#159

@toabctl
Copy link
Owner

toabctl commented Oct 13, 2022

@danigm could you look at the 2.7 test failures please?

@danigm
Copy link
Contributor Author

danigm commented Oct 13, 2022

It looks like this pyproject thing is not implemented in python2 so everything is 'UNKNOWN', so maybe we can skip this test for python2

@toabctl
Copy link
Owner

toabctl commented Oct 13, 2022

@danigm now the linter failed

Following the doc from setuptools, when there's no setup.py file it's
possible to use a simple one with just the call to `setup()` that will
get the data from pyproject.toml:
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#configuring-setuptools-using-pyproject-toml-files

This should fix the issue in py2pack trying to generate from projects
that doesn't provide a setup.py file:
openSUSE/py2pack#159
@toabctl toabctl merged commit a6f4ed0 into toabctl:master Oct 13, 2022
@toabctl
Copy link
Owner

toabctl commented Oct 13, 2022

I’ll do a new pypi release after lunch

@toabctl
Copy link
Owner

toabctl commented Oct 13, 2022

@danigm https://build.opensuse.org/request/show/1010497 is the SR. I guess you are interested in that, right? :)

@danigm
Copy link
Contributor Author

danigm commented Oct 14, 2022

@danigm https://build.opensuse.org/request/show/1010497 is the SR. I guess you are interested in that, right? :)

yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants