Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deburr hyphens; reward typographically exact matches #57

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

lynn
Copy link
Contributor

@lynn lynn commented May 26, 2024

Right now searching bu-she does not find bụshe. This PR fixes that, by editing a regex in deburr to make it discard hyphens entirely.

But now there is no longer a difference between searching bu and bu-. So, to float the right one to the top for either query, let's award bonus points to entries that match a bare search term exactly (pre-deburring).

Copy link
Collaborator

@uakci uakci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging =:3

@uakci uakci merged commit ecf7896 into main Jul 15, 2024
2 checks passed
@uakci uakci deleted the deburr-hyphen branch July 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants