Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if no search range parameter is specified #212

Closed
snilsn opened this issue Dec 5, 2022 · 3 comments
Closed

Raise error if no search range parameter is specified #212

snilsn opened this issue Dec 5, 2022 · 3 comments
Assignees
@snilsn
Labels
bug Code that is failing or producing the wrong result
Milestone
Version 1.5

Comments

@snilsn
Copy link
Collaborator

snilsn commented Dec 5, 2022

We should raise a specific error if neither v_max, d_max nor d_min is provided in linking_trackpy.
@snilsn
Copy link
Collaborator Author

snilsn commented Dec 5, 2022 •
edited
Loading

If nobody is opposed to that, I would like to use this issue (and a corresponding PR) as introduction to our workflow for my successor in early January.

@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Dec 5, 2022
@freemansw1
Copy link
Member

I think that makes sense. Thanks for the bug report and plan, @snilsn. I'll wait to tag this with a milestone until we have a clearer idea of the v1.5 timetable.

@snilsn snilsn changed the title Raise error of no search range parameter is specified Raise error if no search range parameter is specified Dec 6, 2022
@lettlini lettlini mentioned this issue Jan 12, 2023
Merged
11 tasks
@freemansw1 freemansw1 added this to the Version 1.5 milestone Jan 20, 2023
freemansw1 added a commit that referenced this issue Jan 27, 2023
@freemansw1
Merge pull request #223 from lettlini/arguments_bug
2b43edf 
Resolves #212
@freemansw1
Copy link
Member

This has been fixed with #223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snilsn snilsn

Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Version 1.5
Development

No branches or pull requests
2 participants
@freemansw1 @snilsn