Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link #4

Closed
zxdawn opened this issue Dec 24, 2018 · 1 comment
Closed

Wrong link #4

zxdawn opened this issue Dec 24, 2018 · 1 comment

Comments

@zxdawn
Copy link
Collaborator

zxdawn commented Dec 24, 2018

It should be

git clone https://github.com/climate-processes/tobac.git

instead of

git clone https://github.com/mheikenfeld/climate-processes/tobac.git

when cloning this package.
@mheikenfeld
Copy link
Member

Thanks for the heads up, I have just fixed it!

freemansw1 added a commit to galexsky/tobac that referenced this issue May 2, 2022
@freemansw1 @galexsky
Updated the tracking function to the new, faster option (tobac-project#4
df6b6b0 
)

* Updated the tracking function to the new, faster option

In addition to updating the tracking, I've added a Dockerfile in here for easier testing using pytest.

* Added pycache to the gitignore

* Update tracking.py

Added the 3D version of the updated tracking function. Looks and works essentially the same as the original, but the function name has a '_3D' appended to it and the function's guts now include the vertical dimension 'vdim' in the arguments for the trackpy link/link_df functions.

* Update tracking.py

Tweaked "my_linking_trackpy_3D" to change it to "linking_trackpy_3D" for consistency with the non-3D function name

* Update tracking.py

Removed 3D tracking function so we can merge with consistency.

Co-authored-by: galexsky <90701223+galexsky@users.noreply.github.com>
freemansw1 added a commit that referenced this issue Sep 12, 2022
@freemansw1
Merge pull request #4 from freemansw1/doc-changes-parameter-updates
fe118aa 
Doc changes parameter updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mheikenfeld @zxdawn