Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

level parameter in segmentation doesn't do anything #91

Closed
freemansw1 opened this issue Mar 19, 2022 · 1 comment
Closed

level parameter in segmentation doesn't do anything #91

freemansw1 opened this issue Mar 19, 2022 · 1 comment
Assignees
@freemansw1
Labels
bug Code that is failing or producing the wrong result
Milestone
Version 1.3

Comments

@freemansw1
Copy link
Member

The level parameter currently present in tobac.segmentation.segmentation_timestep currently does not actually affect the markers, unlike what the docstring claims. This is, IMO, a pretty severe bug and should probably be addressed immediately. I'll start work on a PR now.
@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Mar 19, 2022
@freemansw1 freemansw1 added this to the Version 1.3 milestone Mar 19, 2022
@freemansw1 freemansw1 self-assigned this Mar 19, 2022
@freemansw1 freemansw1 mentioned this issue Mar 19, 2022
Merged
@freemansw1
Copy link
Member Author

Resolved with #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freemansw1 freemansw1

Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Version 1.3
Development

No branches or pull requests
1 participant
@freemansw1