Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed level parameter in segmentation to work and added segmentation tests #92

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

freemansw1
Copy link
Member

Resolves #91 and adds new tests to our segmentation function to ensure that level limits the vertical levels that are seeded when using columnar seeding in segmentation.

…ests

Added new test of 3D segmentation to make sure that new levels actually works.
@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Mar 19, 2022
@freemansw1 freemansw1 added this to the Version 1.3 milestone Mar 19, 2022
@freemansw1 freemansw1 requested a review from w-k-jones March 19, 2022 20:59
@freemansw1 freemansw1 self-assigned this Mar 19, 2022
@freemansw1 freemansw1 changed the title Fixed level parameter in segmentation to actually work and added segmentation tests Fixed level parameter in segmentation to work and added segmentation tests Mar 19, 2022
tobac/segmentation.py Outdated Show resolved Hide resolved
Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged

@freemansw1 freemansw1 merged commit cef3cdf into tobac-project:dev Mar 22, 2022
@freemansw1 freemansw1 deleted the fix_level_segmentation branch March 22, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants