Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function to combine feature dataframes #186

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

freemansw1
Copy link
Member

This should address #17 (!) and provides a function for combining multiple, independently identified feature dataframes into a single dataframe appropriate for tracking.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added enhancement Addition of new features, or improved functionality of existing features documentation Updates and improvements to documentation and examples labels Oct 21, 2022
@freemansw1 freemansw1 added this to the Version 1.4 milestone Oct 21, 2022
@freemansw1 freemansw1 changed the base branch from main to RC_v1.4.0 October 21, 2022 02:56
@freemansw1
Copy link
Member Author

I should note that the original idea for this came from some code that @JuliaKukulies posted that I found a couple years ago on #17.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 35.06% // Head: 35.58% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (dedefdb) compared to base (dfe3b38).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           RC_v1.4.0     #186      +/-   ##
=============================================
+ Coverage      35.06%   35.58%   +0.52%     
=============================================
  Files             10       10              
  Lines           2099     2116      +17     
=============================================
+ Hits             736      753      +17     
  Misses          1363     1363              
Flag Coverage Δ
unittests 35.58% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tobac/utils.py 50.40% <100.00%> (+3.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@freemansw1 freemansw1 linked an issue Oct 21, 2022 that may be closed by this pull request
Copy link
Collaborator

@snilsn snilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, @freemansw1 ! The function is very well thought out, and I have tested it by splitting the test data sets. It's working flawlessly. All of my comments are just some minor details, therefore I'm approving this PR.

tobac/utils.py Outdated Show resolved Hide resolved
tobac/utils.py Outdated Show resolved Hide resolved
tobac/tests/test_utils.py Outdated Show resolved Hide resolved
tobac/tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for taking care of this @freemansw1! Your code works well and the documentation is clear and helpful! I have only a small question. Otherwise, nothing to add.

tobac/utils.py Show resolved Hide resolved
@freemansw1
Copy link
Member Author

Ok, since I've added new functionality, will wait for @JuliaKukulies and @snilsn to confirm (and CI to pass) before merging. Thanks to both of you for your very quick reviews!

@snilsn
Copy link
Collaborator

snilsn commented Oct 21, 2022

No concerns from my side @freemansw1

@JuliaKukulies
Copy link
Member

Not from my side either. Please go ahead and merge @freemansw1

And thank you very much for the addition, I find it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates and improvements to documentation and examples enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large netCDF files
3 participants