Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added github action for checking .zenodo.json formatting #292

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

lettlini
Copy link
Collaborator

@lettlini lettlini commented Jun 1, 2023

This is a draft Github action that checks the formatting of .zenodo.json.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa7a194) 54.60% compared to head (1bc805b) 54.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.0     #292   +/-   ##
==========================================
  Coverage      54.60%   54.60%           
==========================================
  Files             15       15           
  Lines           3170     3170           
==========================================
  Hits            1731     1731           
  Misses          1439     1439           
Flag Coverage Δ
unittests 54.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Codecov test failed during the result upload, so I've re-run and it should be fine

edit: missed that this is still in draft, please request re-review if needed

@lettlini lettlini marked this pull request as ready for review June 9, 2023 11:52
@freemansw1
Copy link
Member

Neat! This resolves #178

@freemansw1 freemansw1 added this to the Version 1.5 milestone Jun 9, 2023
@freemansw1 freemansw1 merged commit ce9d35f into tobac-project:RC_v1.5.0 Jul 5, 2023
@lettlini lettlini deleted the feature/validate_json branch July 5, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants