Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back standardize_track_dataset #330

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Aug 21, 2023

We inadvertently removed standardize_track_dataset when we reworked the utils functions in #191. I've added it back here to utils/general.py.

I've marked this to merge with the hotfix branch, as I think it would be ideal to get this into v1.5.1.

This resolves #329.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Aug 21, 2023
@freemansw1 freemansw1 added this to the Version 1.5.x milestone Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.31% ⚠️

Comparison is base (d819159) 56.04% compared to head (c7b0401) 55.74%.
Report is 8 commits behind head on RC_v1.5_hotfix.

Additional details and impacted files
@@                Coverage Diff                 @@
##           RC_v1.5_hotfix     #330      +/-   ##
==================================================
- Coverage           56.04%   55.74%   -0.31%     
==================================================
  Files                  15       15              
  Lines                3290     3310      +20     
==================================================
+ Hits                 1844     1845       +1     
- Misses               1446     1465      +19     
Flag Coverage Δ
unittests 55.74% <12.50%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tobac/utils/__init__.py 100.00% <ø> (ø)
tobac/utils/general.py 70.84% <12.50%> (-1.63%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged without passing the test coverage requirement

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also happy to merge and get this out together with the hotfix.

@freemansw1 freemansw1 merged commit a23a220 into tobac-project:RC_v1.5_hotfix Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants