-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding checklists for the issue tracker #358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #358 +/- ##
=============================================
+ Coverage 55.75% 56.79% +1.03%
=============================================
Files 15 20 +5
Lines 3316 3435 +119
=============================================
+ Hits 1849 1951 +102
- Misses 1467 1484 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on, @fziegner . This is indeed what I had in mind. I've made a small comment, but I think this is overall ready to be moved out of draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding this! We can always add more templates in future (e.g. a feature request template), but I think it's best to add these straight away
Thanks for the reviews. I'll remove the draft status then. |
I'm happy to merge as well, as the Jupyter CI issue has nothing to do with this PR |
Yes @freemansw1, no objections from me. |
This PR addresses #174 by adding templates for the issue tracker. I checked how projects like pandas and numpy manage this which mostly is in the form of interactive forms using YAML. These don't allow editing the issue while creating it so I opted to use Markdown in the style of the pull request template.
I created a repository here so you can check out how the templates look like in action. Is this what you had in mind @freemansw1? Unfortunately, Markdown doesn't support variables so you'd still have to manually replace the version number in the release template.