Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtd integration of notebooks #411

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

fsenf
Copy link
Member

@fsenf fsenf commented Feb 28, 2024

I explore read-the-docs integration of our examples. I chose sphinx-gallery, see https://docs.readthedocs.io/en/stable/guides/jupyter.html#creating-galleries-of-examples-using-notebooks

This dev is branched off https://github.com/fsenf/tobac/tree/backintegration_of_tutorials and thus need to wait for #334 being back-integrated.

This fixes #409

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

- a symbolic link is placed in doc
- sphinx-gallery is added in conf.py and requirements
- some notebooks cells were tagged for thumbnails
- figure changed in vorticity notebooks
@fsenf fsenf added this to the Version 1.5.3 milestone Feb 28, 2024
Copy link

github-actions bot commented Feb 28, 2024

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones
Copy link
Member

w-k-jones commented Feb 28, 2024

This looks really nice! I can review after #334 is merged

@fsenf
Copy link
Member Author

fsenf commented Feb 28, 2024

Here is this direct link to the rendered gallery for your convenience: https://tobac--411.org.readthedocs.build/en/411/examples.html

... there is room for improvement ... let's hope that some skilled people come around in future ;-)

@fsenf fsenf requested a review from w-k-jones February 28, 2024 17:21
@freemansw1
Copy link
Member

@fsenf this is beautiful and a preeminent example of what our documentation should be. Let's get this in ASAP after #334 is in.

@JuliaKukulies
Copy link
Member

Wow, very nice @fsenf ! Are you going to do the second review @freemansw1 ? If not, I can also review after #334

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.00%. Comparing base (cb44192) to head (df86e7f).

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.x     #411   +/-   ##
==========================================
  Coverage      57.00%   57.00%           
==========================================
  Files             20       20           
  Lines           3454     3454           
==========================================
  Hits            1969     1969           
  Misses          1485     1485           
Flag Coverage Δ
unittests 57.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsenf
Copy link
Member Author

fsenf commented Feb 29, 2024

OK, #334 is done!

I updated this PR accordingly to hold also the newest changes of https://github.com/tobac-project/tobac/tree/RC_v1.5.x

@w-k-jones & @JuliaKukulies : It is ready for review now. Thank you for your willingness to review the PR!

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! My only suggestions are regarding the naming of different sections, but I'll leave it open to your judgement whether you like these changes or not

doc/examples.rst Outdated Show resolved Hide resolved
doc/examples.rst Outdated Show resolved Hide resolved
doc/examples.rst Outdated Show resolved Hide resolved
Proper Renaming of Gallery Headlines

Co-authored-by: William Jones <william.jones@physics.ox.ac.uk>
@fsenf
Copy link
Member Author

fsenf commented Mar 5, 2024

HI @JuliaKukulies , what is your opinion on this contribution?

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - excellent contribution @fsenf! Just a tiny syntax correction after your headlines update. Otherwise, the PR is ready to be merged.

doc/examples.rst Outdated Show resolved Hide resolved
doc/examples.rst Outdated Show resolved Hide resolved
correct tobac to italic

Co-authored-by: Julia Kukulies <44163060+JuliaKukulies@users.noreply.github.com>
@fsenf
Copy link
Member Author

fsenf commented Mar 5, 2024

great! Thank you for your superfast feedback! I will merge it after testing is finished.

@fsenf fsenf merged commit adf125a into tobac-project:RC_v1.5.x Mar 6, 2024
21 checks passed
@fsenf fsenf deleted the rtd-integration-of-notebooks branch March 6, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants