-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtd integration of notebooks #411
Rtd integration of notebooks #411
Conversation
- a symbolic link is placed in doc - sphinx-gallery is added in conf.py and requirements - some notebooks cells were tagged for thumbnails - figure changed in vorticity notebooks
Linting results by Pylint:Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) |
This looks really nice! I can review after #334 is merged |
Here is this direct link to the rendered gallery for your convenience: https://tobac--411.org.readthedocs.build/en/411/examples.html ... there is room for improvement ... let's hope that some skilled people come around in future ;-) |
Wow, very nice @fsenf ! Are you going to do the second review @freemansw1 ? If not, I can also review after #334 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #411 +/- ##
==========================================
Coverage 57.00% 57.00%
==========================================
Files 20 20
Lines 3454 3454
==========================================
Hits 1969 1969
Misses 1485 1485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OK, #334 is done! I updated this PR accordingly to hold also the newest changes of https://github.com/tobac-project/tobac/tree/RC_v1.5.x @w-k-jones & @JuliaKukulies : It is ready for review now. Thank you for your willingness to review the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! My only suggestions are regarding the naming of different sections, but I'll leave it open to your judgement whether you like these changes or not
Proper Renaming of Gallery Headlines Co-authored-by: William Jones <william.jones@physics.ox.ac.uk>
HI @JuliaKukulies , what is your opinion on this contribution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - excellent contribution @fsenf! Just a tiny syntax correction after your headlines update. Otherwise, the PR is ready to be merged.
correct tobac to italic Co-authored-by: Julia Kukulies <44163060+JuliaKukulies@users.noreply.github.com>
great! Thank you for your superfast feedback! I will merge it after testing is finished. |
I explore read-the-docs integration of our examples. I chose sphinx-gallery, see https://docs.readthedocs.io/en/stable/guides/jupyter.html#creating-galleries-of-examples-using-notebooks
This dev is branched off https://github.com/fsenf/tobac/tree/backintegration_of_tutorials and thus need to wait for #334 being back-integrated.
This fixes #409