-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing thumbnails for notebook gallery #428
Fix missing thumbnails for notebook gallery #428
Conversation
Linting results by Pylint:Your code has been rated at 8.69/10 (previous run: 8.69/10, +0.00) |
I included a colorful set of thumbnail images. Hope that looks nice now ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my thumbnail update all looks fine! Thank you!
@w-k-jones : this documentation piece is ready. Would you like to act as 2nd reviewer? PS: Unfortunately, the website under the link above did not update to show the newest image versions.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The new images are showing up for me in the test build. Happy for this to be merged
edit: just double checked, are the images for the segmentation basics and linking basics swapped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick change then I'm happy to merge
This PR addresses #426. The thumbnails are now saved in the _static directory instead of being selected from the notebooks. This also makes it possible to choose specific thumbnails for the gallery. Some of the thumbnails are still suboptimal so I'll be looking for a way to improve them.