Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing thumbnails for notebook gallery #428

Merged
merged 7 commits into from
May 28, 2024

Conversation

fziegner
Copy link
Collaborator

@fziegner fziegner commented May 8, 2024

This PR addresses #426. The thumbnails are now saved in the _static directory instead of being selected from the notebooks. This also makes it possible to choose specific thumbnails for the gallery. Some of the thumbnails are still suboptimal so I'll be looking for a way to improve them.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

github-actions bot commented May 8, 2024

Linting results by Pylint:

Your code has been rated at 8.69/10 (previous run: 8.69/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@fsenf
Copy link
Member

fsenf commented May 8, 2024

@fsenf fsenf added this to the Version 1.5.4 milestone May 17, 2024
@fsenf
Copy link
Member

fsenf commented May 28, 2024

I included a colorful set of thumbnail images. Hope that looks nice now ...

@fsenf fsenf marked this pull request as ready for review May 28, 2024 11:14
Copy link
Member

@fsenf fsenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my thumbnail update all looks fine! Thank you!

@fsenf
Copy link
Member

fsenf commented May 28, 2024

@w-k-jones : this documentation piece is ready. Would you like to act as 2nd reviewer?

PS: Unfortunately, the website under the link above did not update to show the newest image versions....

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The new images are showing up for me in the test build. Happy for this to be merged

edit: just double checked, are the images for the segmentation basics and linking basics swapped?

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change then I'm happy to merge

doc/conf.py Outdated Show resolved Hide resolved
@fsenf fsenf requested a review from w-k-jones May 28, 2024 11:56
@fsenf fsenf merged commit 2d1cc4a into tobac-project:RC_v1.5.x May 28, 2024
17 of 19 checks passed
@freemansw1 freemansw1 linked an issue Jun 21, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnails for Notebook Gallery Got Lost
3 participants