Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point error in 2d/3d coordinate interpolation #434

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Jun 24, 2024

Resolves #433. Clipping of hdim1/2 values to size of dimensions (or size + 1 for periodic coordinates) in feature_location, and extrapolation enabled for 2d/3d coordinates as with 1d coords.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones changed the base branch from main to RC_v1.5.x June 24, 2024 19:24
Copy link

github-actions bot commented Jun 24, 2024

Linting results by Pylint:

Your code has been rated at 8.70/10 (previous run: 8.70/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones w-k-jones requested a review from freemansw1 June 24, 2024 19:26
@w-k-jones w-k-jones added the bug Code that is failing or producing the wrong result label Jun 24, 2024
@w-k-jones w-k-jones self-assigned this Jun 24, 2024
@w-k-jones w-k-jones added this to the Version 1.5.4 milestone Jun 24, 2024
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @w-k-jones . I'm happy with these changes. We should probably back-propagate them to #354 once this is merged and add a test to make sure it works the same across the two paths.

@fsenf fsenf requested a review from fziegner July 31, 2024 12:58
Copy link
Collaborator

@fziegner fziegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I found no issues.

@freemansw1
Copy link
Member

@w-k-jones, are you happy to merge? Only issue seems to be codecov.

@w-k-jones w-k-jones merged commit 4fa1efa into tobac-project:RC_v1.5.x Sep 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating point error in feature detection breaks interpn
3 participants