-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating point error in 2d/3d coordinate interpolation #434
Fix floating point error in 2d/3d coordinate interpolation #434
Conversation
Linting results by Pylint:Your code has been rated at 8.70/10 (previous run: 8.70/10, +0.00) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @w-k-jones . I'm happy with these changes. We should probably back-propagate them to #354 once this is merged and add a test to make sure it works the same across the two paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I found no issues.
@w-k-jones, are you happy to merge? Only issue seems to be codecov. |
Resolves #433. Clipping of hdim1/2 values to size of dimensions (or size + 1 for periodic coordinates) in
feature_location
, and extrapolation enabled for 2d/3d coordinates as with 1d coords.