Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.5.4 #459

Merged
merged 122 commits into from
Oct 21, 2024
Merged

Release v1.5.4 #459

merged 122 commits into from
Oct 21, 2024

Conversation

freemansw1
Copy link
Member

PR for v1.5.4 release

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

w-k-jones and others added 30 commits November 29, 2023 11:37
@freemansw1 freemansw1 self-assigned this Oct 18, 2024
@freemansw1 freemansw1 added this to the Version 1.5.4 milestone Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 83.52941% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (698d53b) to head (2d708be).
Report is 145 commits behind head on main.

Files with missing lines Patch % Lines
tobac/utils/general.py 53.33% 14 Missing ⚠️
tobac/feature_detection.py 76.08% 11 Missing ⚠️
tobac/utils/bulk_statistics.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   60.91%   60.72%   -0.19%     
==========================================
  Files          23       23              
  Lines        3541     3537       -4     
==========================================
- Hits         2157     2148       -9     
- Misses       1384     1389       +5     
Flag Coverage Δ
unittests 60.72% <83.52%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 18, 2024

Linting results by Pylint:

Your code has been rated at 8.70/10 (previous run: 8.70/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the main branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the release! There is one issue I spotted in the rendering of one of the notebooks, but once that is resolved I'm happy for this to be merged and released

@freemansw1 freemansw1 mentioned this pull request Oct 20, 2024
9 tasks
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks for doing the release @freemansw1 !

@freemansw1 freemansw1 merged commit 343243f into main Oct 21, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants