Upstream berskfile support #231
Conversation
Conflicts: tests/test_command.py tests/test_runner.py
… and run chef-solo from it. Conflicts: littlechef/solo.py
… vendor directory after.
| @@ -278,7 +278,8 @@ def get_recipes_in_cookbook(name): | |||
| path = None | |||
| cookbook_exists = False | |||
| metadata_exists = False | |||
| for cookbook_path in cookbook_paths: | |||
|
|
|||
| for cookbook_path in env.cookbook_search_paths: | |||
There was a problem hiding this comment.
What is cookbook_search_paths for? I didn't find where it is initialized anywere...
OK, sorry, in _readconfig. But why not use cookbook_paths? It can be directly modified in the same way to append berksfile directories
There was a problem hiding this comment.
When I wrote this code I thought that it would be better to have one main arrays for all cookbook paths where others will be merged, because cookbook_paths were user customizable.
So I use cookbook_paths as place where to look for non berkshelf cookbooks and berksfile_cookbooks_directory as a place where I will berks vendor cookbooks. Then I will add both directories to one array and use them later.
| @@ -45,6 +45,7 @@ | |||
|
|
|||
| __testing__ = False | |||
|
|
|||
| env.berksfile_cookbooks_directory="" | |||
There was a problem hiding this comment.
There should be spaces to both sides of the equality sign. Also a better place to put this statement would be further up, for example right below env.node_work_path = littlechef.node_work_path
No description provided.