Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting of Deluge address via environment variable DELUGE_HOST #1

Closed
wants to merge 1 commit into from

Conversation

jangrewe
Copy link
Contributor

@jangrewe jangrewe commented Nov 9, 2018

add Dockerfile

Run it like this:

docker run -e "DELUGE_HOST=172.17.0.1" -v /etc/deluge:/root/.config/deluge/ -p 9354:9354 registry.example.com/deluge_exporter:latest

@tobbez
Copy link
Owner

tobbez commented Nov 11, 2018

Code looks good as far as I can tell (don't use docker much).

Please split the commit into one for each distinct change (one for DELUGE_HOST support, one for the Dockerfile).

Or would you prefer if I just split it myself and merged it?

@jangrewe
Copy link
Contributor Author

You can split it if you want, i didn't plan on maintaining an long term fork. ;-)
Could you also sign up with hub.docker.com to have this image built automatically on push, so that there's an official one?

And a bit off-topic, but: what do you think of merging all the deluge_libtorrent_*_download_bytes_total metrics into a single deluge_libtorrent_download_bytes_total{type="*"} metric (same for the upload metrics, of course), so using labels instead of separate metrics? I guess that's a bit more Prometheus-style ;-)

@tobbez tobbez closed this in ca4bca4 Nov 11, 2018
@tobbez
Copy link
Owner

tobbez commented Nov 11, 2018

There's now an image on docker hub.

The upload and download metrics have also been consolidated (ffa8b29).

@jangrewe
Copy link
Contributor Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants