Compile against openssl 1.1+ and with gcc-8 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc-8 creates this: |ipseckey.c: In function 'ipseckey_human': |ipseckey.c:114:35: error: '%s' directive output may be truncated writing up to 1023 bytes into a region of size between 1010 and 1016 [-Werror=format-truncation=] Avoid the warning by limiting the length of the string. BTS: https://bugs.debian.org/897882 Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
[bigeasy: drop locking, check for OOM during allocation.] BTS: https://bugs.debian.org/859784 Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
Is there any update on this I fail to build this on RHEL 8 (#76) and I believe I am encountering this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch gets it compiled with gcc-8.
Second patch is updated patch initially made by FauxFaux. I addressed my own review by checking for possible NULL pointer and dropping the locking which is obsolete in openssl 1.1.