Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs, more errors, fix tests, add examples. #1

Merged
merged 12 commits into from
Apr 20, 2014
Merged

Conversation

aybabtme
Copy link
Contributor

Good morning!

  • Add docs: I've written some docs for all the exported fields.
  • Add examples: I replaced the example/resize.go file by Go examples, which are part of the test suite and show up in the docs.

See the docs + examples : http://godoc.org/github.com/aybabtme/mogrify-go

  • More errors: replaced some calls that required nil-checks (not idiomatic in Go) by errors. I think more could be done for the cases where methods on gdImage panics for various operations that could be errors. However I'm not familiar enough so I didn't venture this way.
  • Fix tests: the tests were passing an asset string argument to the asset(...) helper func, which was diligently ignoring it and always opening the same file.

r: @tobi
cc: @boourns
This PR includes commits I've found in @boourns fork, so this builds on top of it.

tobi added a commit that referenced this pull request Apr 20, 2014
Add docs, more errors, fix tests, add examples.
@tobi tobi merged commit 6383d92 into tobi:master Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants