Support New Interface on Pre-Existing Related Interface #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opps, ill fix the lint issues in the morning... |
ChrisPortman
force-pushed
the
support-interface-to-preexisting-lag
branch
3 times, most recently
from
7973684 to
e24ed3a
Compare
If an interface specifies a non-parent (e.g. 'lag') interface, establish the relationship when the related interface is pre-existing.
tobiasge
force-pushed
the
support-interface-to-preexisting-lag
branch
from
e24ed3a to
8c7222e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an interface specifies a non-parent (e.g. 'lag') interface, establish the relationship when the related interface is pre-existing.
Previously the relationship was only established if the LAG interface was created as part of creating the member. There was no way then to add a 2nd member to the LAG or pre-create the LAG interface with other attributes set.
Now, you can (optionally) pre-create the LAG with whatever attributes are required (e.g. MAC address) and then specifiy members and they will be added to the LAG. Alternatively, you can omit the explicit specification of the LAG and have it create with the first member (as per previous behavior), subsequent interfaces specifying the same LAG will now join as expected.