-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for WebIDL moving to WHATWG #686
Conversation
Ugh. There's more stuff to cleanup in w3c.json. |
See also the conversation at: #677 /cc @marcoscaceres |
What would the best course of action be here, also delete the -1 and -2 aliases? Does that need a policy discussion/decision now the document has moved? And if yes, is that documented somewhere since I'm not sure what it entails? |
@annevk: I'm going to confess having very little time to focus on this atm and don't want to be blocking y'all from moving forward with this. I'm happy with whatever you, @tabatkins, and @marcoscaceres agree to. |
Thanks and understood; I hope @marcoscaceres can chime in tomorrow with the best course of action here. |
I think we should do what @tabatkins suggested:
And same with Let me see what's left over in w3c.json... |
Updating this PR locally... will send something up soon. |
ok, did the re-alias so no references are lost. Now all point to the right place ("WEBIDL"). @tobie, can you give it a once over to make sure it looks right? |
I'm afraid this won't work. Both w3c.json (as I understand it) and whatwg.json would be overridden with the next update. whatwg.json is essentially https://resources.whatwg.org/biblio.json. Instead this information needs to be patched in through overrides. |
Oh yeah, of course... sorry, it's been a while since I hacked on this... if I transfer those aliases to biblio.js, then that's gonna help.... then we need to add the version somehow to "WEBIDL" in whatwg.json |
@annevk, can we add the version directly to "biblio.json" on the WHATWG side? |
On the WHATWG side we generate that file automatically and don't have a good way of adding additional data to it. We could probably put something together, but I'd rather we do it here somehow. |
Ok, I'll investigate. |
Have you tried running an update over your code changes? It might well work? |
a944798
to
34d9cbb
Compare
No. Which scripts should I run? |
Ok, this works for me locally (if I manually do what the overrides are doing)... Do I need to commit with overwrites in place? (also, how do I run the overwrites)? |
I merged in the refs/w3c.json and refs/whatwg.json changes, which would be equivalent to what the overwrite script would do (even if they get blown away on update). Just to show it works. |
Not behind my desk atm, sorry for not being super responsive. You want to just run the following lines: https://github.com/tobie/specref/blob/main/scripts/update-all#L39-L55 |
@tobie no problem. I'll finish this off tomorrow or later today... quick questions: what do I set the |
Don’t run the whole script. Just copy/paste these lines. |
b4e674a
to
e147629
Compare
Argh... not quite right yet. Getting there tho. |
Ok, I think I got it... 😅 |
Fun thing: CSS now tries to add the old WebIDL reference back in. |
aa30bdb
to
da052d6
Compare
This LGTM. Let's deploy and see what happens. |
Thanks @marcoscaceres and @tobie! I hope this works. |
Continuing the thread in #677 as notifications on merged pull requests are uncharted territory to me. |
/cc @annevk