Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for WebIDL moving to WHATWG #686

Merged
merged 13 commits into from
Oct 7, 2021
Merged

Account for WebIDL moving to WHATWG #686

merged 13 commits into from
Oct 7, 2021

Conversation

tobie
Copy link
Owner

@tobie tobie commented Oct 5, 2021

/cc @annevk

@tobie tobie changed the title Account for WebIdl moving to WHATWG Account for WebIDL moving to WHATWG Oct 5, 2021
@tobie
Copy link
Owner Author

tobie commented Oct 5, 2021

Ugh. There's more stuff to cleanup in w3c.json.

@tobie
Copy link
Owner Author

tobie commented Oct 5, 2021

See also the conversation at: #677

/cc @marcoscaceres

@annevk
Copy link
Collaborator

annevk commented Oct 5, 2021

What would the best course of action be here, also delete the -1 and -2 aliases? Does that need a policy discussion/decision now the document has moved? And if yes, is that documented somewhere since I'm not sure what it entails?

@tobie
Copy link
Owner Author

tobie commented Oct 5, 2021

@annevk: I'm going to confess having very little time to focus on this atm and don't want to be blocking y'all from moving forward with this. I'm happy with whatever you, @tabatkins, and @marcoscaceres agree to.

@annevk
Copy link
Collaborator

annevk commented Oct 5, 2021

Thanks and understood; I hope @marcoscaceres can chime in tomorrow with the best course of action here.

@marcoscaceres
Copy link
Collaborator

I think we should do what @tabatkins suggested:

I recommend that WebIDL-1 be changed to an alias of WebIDL

And same with WebIDL-2.

Let me see what's left over in w3c.json...

@marcoscaceres
Copy link
Collaborator

Updating this PR locally... will send something up soon.

@marcoscaceres
Copy link
Collaborator

ok, did the re-alias so no references are lost.

Now all point to the right place ("WEBIDL").

@tobie, can you give it a once over to make sure it looks right?

@annevk
Copy link
Collaborator

annevk commented Oct 6, 2021

I'm afraid this won't work. Both w3c.json (as I understand it) and whatwg.json would be overridden with the next update. whatwg.json is essentially https://resources.whatwg.org/biblio.json.

Instead this information needs to be patched in through overrides.

@marcoscaceres
Copy link
Collaborator

Oh yeah, of course... sorry, it's been a while since I hacked on this... if I transfer those aliases to biblio.js, then that's gonna help.... then we need to add the version somehow to "WEBIDL" in whatwg.json

@marcoscaceres
Copy link
Collaborator

@annevk, can we add the version directly to "biblio.json" on the WHATWG side?

@annevk
Copy link
Collaborator

annevk commented Oct 6, 2021

On the WHATWG side we generate that file automatically and don't have a good way of adding additional data to it. We could probably put something together, but I'd rather we do it here somehow.

@marcoscaceres
Copy link
Collaborator

Ok, I'll investigate.

@tobie
Copy link
Owner Author

tobie commented Oct 6, 2021

Have you tried running an update over your code changes? It might well work?

@marcoscaceres
Copy link
Collaborator

Have you tried running an update over your code changes? It might well work?

No. Which scripts should I run?

@marcoscaceres
Copy link
Collaborator

Ok, this works for me locally (if I manually do what the overrides are doing)... Do I need to commit with overwrites in place?

(also, how do I run the overwrites)?

@marcoscaceres
Copy link
Collaborator

I merged in the refs/w3c.json and refs/whatwg.json changes, which would be equivalent to what the overwrite script would do (even if they get blown away on update). Just to show it works.

@tobie
Copy link
Owner Author

tobie commented Oct 6, 2021

Not behind my desk atm, sorry for not being super responsive.

You want to just run the following lines: https://github.com/tobie/specref/blob/main/scripts/update-all#L39-L55

@marcoscaceres
Copy link
Collaborator

marcoscaceres commented Oct 6, 2021

@tobie no problem. I'll finish this off tomorrow or later today... quick questions: what do I set the GITHUB_REPO env var to?

@tobie
Copy link
Owner Author

tobie commented Oct 6, 2021

Don’t run the whole script. Just copy/paste these lines.

@marcoscaceres
Copy link
Collaborator

Argh... not quite right yet. Getting there tho.

@marcoscaceres
Copy link
Collaborator

Ok, I think I got it... 😅

@marcoscaceres
Copy link
Collaborator

Fun thing: CSS now tries to add the old WebIDL reference back in.

@tobie
Copy link
Owner Author

tobie commented Oct 7, 2021

This LGTM. Let's deploy and see what happens.

@tobie tobie merged commit 8a0adee into main Oct 7, 2021
@marcoscaceres marcoscaceres deleted the tobie-webidl branch October 7, 2021 06:55
@annevk
Copy link
Collaborator

annevk commented Oct 7, 2021

Thanks @marcoscaceres and @tobie! I hope this works.

@annevk annevk mentioned this pull request Oct 7, 2021
19 tasks
@tobie
Copy link
Owner Author

tobie commented Oct 7, 2021

Continuing the thread in #677 as notifications on merged pull requests are uncharted territory to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants