Implement file downloading under g3pylib.recordings.recording
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # workaround for making subsequent aiohttp clientsessions | ||
| # TODO: find a more appropriate solution | ||
| await asyncio.sleep(0.5) |
There was a problem hiding this comment.
This is a workaround to #91.
| # decode returned string if it is base64 encoded, otherwise write it raw | ||
| try: | ||
| value = base64.b64decode(encoded_value).decode() | ||
| except ValueError: |
There was a problem hiding this comment.
I found that the default metadata like HuSerial, RuSerial and RuVersion are base64-encoded as described in the developer guide, but custom ones, like the ones tests/api_components/test_recording.py::test_meta_data created, are plain text. Is this intended behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Recording.download_files()that downloads all recording files and metadata files to a specified local directory.Resolves #90.