Add PHP to supported Language Map #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I just released version |
abelhegedus
reviewed
Mar 25, 2019
| @@ -19,7 +19,8 @@ const languageMap = { | |||
| "ruby": "Ruby", | |||
| "python": "Python", | |||
| "java": "Java", | |||
| "go": "Go" | |||
| "go": "Go", | |||
| "php: "PHP" | |||
There was a problem hiding this comment.
There's a missing " after "php which causes build failures with 0.3.1
/node_modules/api2html/bin/api2html.js:23
00:00:57.282 "php: "PHP"
00:00:57.282 ^^^
00:00:57.282
00:00:57.282 SyntaxError: Unexpected identifier
00:00:57.282 at new Script (vm.js:74:7)
00:00:57.282 at createScript (vm.js:246:10)
00:00:57.282 at Object.runInThisContext (vm.js:298:10)
00:00:57.282 at Module._compile (internal/modules/cjs/loader.js:670:28)
00:00:57.282 at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
00:00:57.282 at Module.load (internal/modules/cjs/loader.js:612:32)
00:00:57.282 at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
00:00:57.282 at Function.Module._load (internal/modules/cjs/loader.js:543:3)
00:00:57.282 at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
00:00:57.282 at startup (internal/bootstrap/node.js:238:19)
There was a problem hiding this comment.
This should be resolved when PR #20 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an API that can be used by a variety of languages and it doesn't seem that I can specify PHP as a language. I believe this change will allow that?
As mentioned in Issue #18, it'd be nice to be able to specify a Widdershins config file instead to configure it instead of having to use
api2htmlparams.