Skip to content

Bug: "ExpandingRollingIndexer does not implement the correct signature for get_window_bounds" #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tobiscode opened this issue Jan 9, 2023 · 1 comment
Closed

Bug: "ExpandingRollingIndexer does not implement the correct signature for get_window_bounds" #1

tobiscode opened this issue Jan 9, 2023 · 1 comment
Assignees
@tobiscode
Labels
bug Something isn't working

Comments

@tobiscode
Copy link
Owner

tobiscode commented Jan 9, 2023 •
edited
Loading

Hi,

I'm aware of a bug that happens in DISSTANS with pandas versions 1.5 and up when using the ExpandingRollingIndexer (e.g. in the processing.median function). I'm waiting on the outcome of the upstream pandas issue I submitted to see how I will address this issue. For now, downgrading to pandas 1.4 should fix the problem.

Cheers
@tobiscode tobiscode self-assigned this Jan 10, 2023
@tobiscode tobiscode added the bug Something isn't working label Jan 10, 2023
tobiscode added a commit that referenced this issue Feb 22, 2023
@tobiscode
Fix for GH #1 ExpandingRollingIndexer
3956dbe 
- updates the signature of ExpandingRollingIndexer.get_window_bounds
  to the expected one by pandas >= 1.5
- pin the requirements & environment files to pandas >= 1.5
tobiscode added a commit that referenced this issue Feb 28, 2023
@tobiscode
Pin pandas to <1.5 to avoid GH bug #1
2e5665f 
(a newer DISSTANS version will update the signature to
match newer pandas versions)
@tobiscode
Copy link
Owner Author

Fixed for v1.1.2 with 2e5665f, and for v1.2 with 3956dbe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiscode tobiscode

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiscode