Fix(optimizer): handle subquery predicate substitution correctly in d…

…e morgan's rule (#4240)

sqlglot/optimizer/simplify.py

@@ -206,6 +206,11 @@ def rewrite_between(expression: exp.Expression) -> exp.Expression:
  exp.NEQ: exp.EQ,
 }
 
+COMPLEMENT_SUBQUERY_PREDICATES = {
+ exp.All: exp.Any,
+ exp.Any: exp.All,
+}
+
 
 def simplify_not(expression):
  """
@@ -218,9 +223,12 @@ def simplify_not(expression):
  if is_null(this):
  return exp.null()
  if this.__class__ in COMPLEMENT_COMPARISONS:
- return COMPLEMENT_COMPARISONS[this.__class__](
- this=this.this, expression=this.expression
- )
+ right = this.expression
+ complement_subquery_predicate = COMPLEMENT_SUBQUERY_PREDICATES.get(right.__class__)
+ if complement_subquery_predicate:
+ right = complement_subquery_predicate(this=right.this)
+
+ return COMPLEMENT_COMPARISONS[this.__class__](this=this.this, expression=right)
  if isinstance(this, exp.Paren):
  condition = this.unnest()
  if isinstance(condition, exp.And):

tests/fixtures/optimizer/simplify.sql

@@ -140,6 +140,9 @@ TRUE;
 COALESCE(x, y) <> ALL (SELECT z FROM w);
 COALESCE(x, y) <> ALL (SELECT z FROM w);
 
+SELECT NOT (2 <> ALL (SELECT 2 UNION ALL SELECT 3));
+SELECT 2 = ANY(SELECT 2 UNION ALL SELECT 3);
+
 --------------------------------------
 -- Absorption
 --------------------------------------