Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add BYTES type to BigQuery dialect #1536

Merged
merged 5 commits into from
May 3, 2023
Merged

Feat: Add BYTES type to BigQuery dialect #1536

merged 5 commits into from
May 3, 2023

Conversation

relud
Copy link
Contributor

@relud relud commented May 3, 2023

fixes #1533

georgesittas
georgesittas approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

sqlglot/dialects/bigquery.py Show resolved Hide resolved
@georgesittas georgesittas marked this pull request as ready for review May 3, 2023 18:41
@georgesittas georgesittas changed the title Add BYTES type to BigQuery dialect Feat: Add BYTES type to BigQuery dialect May 3, 2023
@tobymao tobymao merged commit e2593ba into tobymao:main May 3, 2023
@relud relud deleted the patch-1 branch May 3, 2023 19:57
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@relud @adrianisk
Feat: Add BYTES type to BigQuery dialect (tobymao#1536)
af1e163 
* Add BYTES type to BigQuery dialect

* Add test

* update bigquery output test

* add output type mapping for bigquery BYTES

* Update test_dialect.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BYTES type not recognized for BigQuery dialect
3 participants
@relud @georgesittas @tobymao