Refactor: preserve the full text of hex/bin literals #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
May 4, 2023
tobymao
reviewed
May 4, 2023
vegarsti
reviewed
May 4, 2023
|
Awesome, thanks so much! |
crericha
reviewed
May 4, 2023
georgesittas
changed the title
tobymao
reviewed
May 5, 2023
tobymao
reviewed
May 5, 2023
tobymao
reviewed
May 5, 2023
tobymao
approved these changes
May 5, 2023
|
Eagerly looking forward to this being released 👀 |
vegarsti
added a commit
to duneanalytics/harmonizer
that referenced
this pull request
May 10, 2023
) #41 and related issues were worked around, but SQLGlot 2.12 includes a [refactor](tobymao/sqlglot#1552) which helps us get rid of that.
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Feat: refactor hex/bit literals so that their text is preserved * Convert hex/bin values by default, make meta class attr setting more robust * Fix parsing for dialects that don't support HEX/BIT_STINGS * Refactor * Apply suggestion * Simplify generator check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref duneanalytics/harmonizer#41
cc: @vegarsti this should simplify your hex string handling in harmonizer.