Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(schema): ensure the correct dialect is used in schema methods #1710

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix(schema): ensure the correct dialect is used in schema methods #1710

merged 1 commit into from
May 31, 2023

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented May 31, 2023 •
edited
Loading

This fixes a bug that I missed in 12d3cca: _ensure_table used to wrap around the dialect or self.dialect logic, whereas in my change I just passed in dialect to maybe_parse. For this reason I reintroduced _ensure_table, in order to avoid doing dialect or self.dialect inline for every exp.maybe_parse call in the schema module.

@tobymao tobymao merged commit dd5457c into main May 31, 2023
@tobymao tobymao deleted the jo/schema_fixup branch May 31, 2023 16:54
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@georgesittas @adrianisk
Fix(schema): ensure the correct dialect is used in schema methods (to…
ac1682d 
…bymao#1710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgesittas @tobymao