Feat!: transpile map retrieval to duckdb, transpile TRY_ELEMENT_AT #3277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB says the following for retrieving values from maps:
This makes it tricky to transpile such retrievals to / from it, because we need to either unwrap / wrap the retrieved value, respectively.
This PR:
-> DuckDB
direction of the transpilationTRY_ELEMENT_AT
functionOne side effect of this change is that when constructing
Bracket
nodes for DuckDB manually, it will also be required to setreturns_list_for_maps
toTrue
, otherwise we'll generate incorrect SQL when targeting DuckDB.References: