PLA-4862 Add materialized argument to with_
#4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
Sep 2, 2024
| @@ -7,6 +7,7 @@ install-dev-rs-release: | |||
| cd sqlglotrs/ && python -m maturin develop -r | |||
|
|
|||
| install-dev-rs: | |||
| @unset CONDA_PREFIX && \ | |||
There was a problem hiding this comment.
I had to add this, as I had a conda prefix set, it's not totally uncommon for makefiles to set this to make things easier. For example, Polars does this: https://github.com/pola-rs/polars/blob/main/Makefile
Let me know if we're fine with keeping it.
There was a problem hiding this comment.
as long as this doesn't break my setup
There was a problem hiding this comment.
It shouldn't! haha
max-muoto
force-pushed
the
support-materialized-ctes
branch
from
fc182cc to
4a76a13
Compare
tobymao
approved these changes
Sep 2, 2024
max-muoto
changed the title
materialized argument to with_materialized argument to with_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
materializedargument when building a CTE withwith_. It's supported in both Postgres and DuckDB:See Slack thread here.