Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename SHA function to SHA1 for DuckDB #4191

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

rustyconover
Copy link
Contributor

Addresses issue #4185

Copy link
Collaborator

@VaggelisD VaggelisD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test case for this, you can either add it to existing multi-dialect SHA tests (as in test_bigquery.py) or add something like this in test_duckdb.py:

        self.validate_all(
            "SHA1(x)",
           read={
              "": "SHA(x)",
            },
            write={
                "duckdb": "SHA1(x)",
                "": "SHA(x)",
            },
        )

@rustyconover
Copy link
Contributor Author

@VaggelisD test added.

@georgesittas georgesittas merged commit 3d1c643 into tobymao:main Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants