Fix: Make exp.Update a DML node #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
approved these changes
Oct 8, 2024
|
Do you have something specific in mind, e.g. should we check each scope individually for this particular case or introduce more |
I was thinking some more |
VaggelisD
force-pushed
the
vaggelisd/update_dml
branch
from
f58af58
to
8a9bb9c
Compare
georgesittas
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4221
This PR:
exp.UpdateaDMLnode as is semantically fitting; This also enablestraverse_scopeon UPDATE statementsexp.Selectchildren of subqueries would be visited twice (one in_traverse_subqueriesand one in thefind_all_in_scope(expression, exp.Query)block)