fix(bigquery)!: Support FORMAT_TIMESTAMP #4383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BQ's
FORMAT_TIMESTAMP
throughexp.TimeToStr
:Regarding the changes in this PR:
FORMAT_DATETIME
was deduplicated fromFORMAT_TIMESTAMP
by introducingexp.TsOrDsToDatetime
exp.cast(...)
, a bug was solved regarding thetypes_are_equivalent
check; Note howget
will either retrieve astr
or aDataType.Type
(the default value), so the comparison might be incorrect as stringifyingDataType
s will prepend them with theType.<type>
enum prefix (e.g comparingType.TIMESTAMP
withDATETIME
for DuckDB). To fix this we must retrieve either theTYPE_MAPPING
or stringify thevalue
of the enum typeType.DATETIME
now maps toTIMESTAMP
as these are aliases (this enables redundant cast eliminations from bullet 2)Docs
BQ FORMAT_TIMESTAMP | DuckDB TIMESTAMP type | Snowflake TO_CHAR