kernel attributes: explain their location #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
approved these changes
Nov 25, 2024
ppannuto
approved these changes
Nov 25, 2024
Comment on lines
+14
to
+15
| in flash and working backwards. | ||
|
|
There was a problem hiding this comment.
Suggested change
| in flash and working backwards. | |
| in flash and working backwards. | |
| Storing attributes at the end also has a secondary benefit of zero-filling the rest of | |
| the flash region. While not essential for correct operation, as unused flash should | |
| always be inaccessible, this provides an additional defense-in-depth step for the | |
| Tock platform by default. | |
There was a problem hiding this comment.
I'm nervous about that because tockloader doesn't always actually write those zeros.
There was a problem hiding this comment.
If we promise to write those zeros in documentation, that'll also make it harder to ship sparse files to accelerate flashing and reduce write cycles. So I wouldn't want to go that far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a little more detail on why kernel attributes are where they are.