Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtock: update breaking driver existence check changes #349

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

Samir-Rashid
Copy link
Contributor

Bring libtock-c into consistency with the changes in this PR.

ppannuto
ppannuto previously approved these changes Oct 6, 2023
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on pending kernel changes.

@ppannuto ppannuto added the blocked Blocked on promised changes or other PRs label Oct 6, 2023
@ppannuto ppannuto removed the blocked Blocked on promised changes or other PRs label Oct 23, 2023
@Samir-Rashid Samir-Rashid marked this pull request as draft October 25, 2023 18:46
@Samir-Rashid
Copy link
Contributor Author

Samir-Rashid commented Oct 28, 2023

To @ppannuto
Rebased and added the header file changes I forgot to do.

@lschuermann
Copy link
Member

@Samir-Rashid I took the liberty to move the discussion about NixOS support in libtock-c to a separate issue: #352 Happy to continue there!

This PR accompanies tock#3613.
@Samir-Rashid
Copy link
Contributor Author

I rebased to master. The tests were passing, so I think this PR should be merged.

@bradjc bradjc enabled auto-merge January 7, 2024 20:51
@bradjc bradjc disabled auto-merge January 7, 2024 21:05
@bradjc bradjc merged commit e361aa1 into tock:master Jan 7, 2024
tyler-potyondy pushed a commit to tyler-potyondy/libtock-c that referenced this pull request Mar 13, 2024
libtock: update breaking driver existence check changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants