Add cycle counter driver and test app #386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
alistair23
reviewed
Apr 2, 2024
libtock/cycle_counter.h
Outdated
Comment on lines
11
to
15
| bool cycle_counter_exists(void); | ||
| int cycle_counter_start(void); | ||
| int cycle_counter_stop(void); | ||
| int cycle_counter_reset(void); | ||
| int cycle_counter_read(int *count); |
There was a problem hiding this comment.
It's probably best to document these in the header file.
It's also worth saying that stop does not reset the counter and it needs to manually be reset
|
Can I ask you follow the new guide? https://github.com/tock/libtock-c/blob/43525b8fedff3531685dbb20b08916addcca0997/doc/guide.md Maybe not the syscalls folder but the naming convention? |
hudson-ayers
force-pushed
the
hudson.ayers/cycle_counter
branch
from
21d0830
to
f8e7bb0
Compare
Also adds a helper function for SuccessU64 syscall return values
hudson-ayers
force-pushed
the
hudson.ayers/cycle_counter
branch
from
f8e7bb0
to
8fd8e7d
Compare
ppannuto
approved these changes
Apr 10, 2024
| } else if (rc == RETURNCODE_ERESERVE) { | ||
| printf("Cycle counter claimed by another app\n"); | ||
| } else if (rc != 0) { | ||
| printf("Cycle counter: other error: %d\n", rc); |
There was a problem hiding this comment.
Suggested change
| printf("Cycle counter: other error: %d\n", rc); | |
| printf("Cycle counter: other error: %d (%s)\n", rc, tock_strerr(rc)); |
|
I will come back to this once the new libtock format is merged |
|
@hudson-ayers is this still on your queue? |
Yeah it is, just have had limited time for Tock stuff and have focused more on kernel stuff. I will get back to this eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a driver for the cycle counter capsule, for which kernel support is being added in tock/tock#3934. It also adds a basic test application which prints the number of cycles required to toggle an LED, after checking that the ability to start and stop the driver has not already been claimed by another app.
Tested by adding the capsule to the nrf52840dk and running this app. It takes about 4000 cycles to toggle an LED from userspace.