Support the latest newlib, libc++ and GCC #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Thanks for updating this! @bradjc do you want to build the toolchains or I should I try and get my hands dirty on Docker?
|
Skimming over the scripts, it seems like you actually want to copy the files in |
bradjc
reviewed
Jun 17, 2024
|
Yes this needs docker files. Also, is this worth our time? |
alistair23
force-pushed
the
alistair/lib-bump
branch
from
750940b
to
35f27e1
Compare
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/lib-bump
branch
from
35f27e1
to
403b675
Compare
|
Docker files are added. The current outdated libc++ and newlib fail to build with GCC 14, so we do need an update. This generally will probably need to be updated with each newlib and GCC release |
bradjc
reviewed
Jun 18, 2024
| RUN apt install -y libmpc-dev file | ||
|
|
||
| # Clone the libtock-c source so we can use the build scripts | ||
| RUN git clone https://github.com/alistair23/libtock-c |
There was a problem hiding this comment.
Suggested change
| RUN git clone https://github.com/alistair23/libtock-c | |
| RUN git clone https://github.com/tock/libtock-c |
There was a problem hiding this comment.
Then it won't build. It's a chicken and egg problem, you need 1607c6b merged first
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bradjc you will need to update the pre-built versions to support GCC 14