layout_riscv32.ld: Update the stack size to work with libtock-rs apps #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the size of the stack, to avoid growing the stack out of bounds. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
jrvanwhy
approved these changes
Feb 24, 2020
|
Whoa, 2 KiB already seemed large to me. I wonder where all the space went... |
|
Can you elaborate what kind of use cases you need such a large stack for? |
|
I have created an issues to point this out: #156 |
|
I'm going to close this (as it isn't required to run hello_world) and we can circle back if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the size of the stack, to avoid growing the stack
out of bounds.
Signed-off-by: Alistair Francis alistair.francis@wdc.com